Comments on: What bothers you most about this code? http://squaregalaxy.com/tech/what-bothers-you-most-about-this-code/ A blog by Jacob Thu, 11 Mar 2010 00:47:19 +0000 http://wordpress.org/?v=2.9.1 hourly 1 By: Bruce http://squaregalaxy.com/tech/what-bothers-you-most-about-this-code/comment-page-1/#comment-7485 Bruce Fri, 18 Apr 2008 18:37:46 +0000 http://jacob.peargrove.com/tech/?p=75#comment-7485 The fact that the assignment has side effects bugs me. It's too easy to introduce errors that way. The fact that the assignment has side effects bugs me. It’s too easy to introduce errors that way.

]]> By: jacob http://squaregalaxy.com/tech/what-bothers-you-most-about-this-code/comment-page-1/#comment-7486 jacob Wed, 02 Apr 2008 16:24:44 +0000 http://jacob.peargrove.com/tech/?p=75#comment-7486 Its one of two lines in a CRC checksum calculation. Whats really scary to me is the *dataBlkPtr++, because the order of operations is not very clear to the code reader. Does it post-increment the dereferenced value, or does it post-increment the pointer after it provides the dereferenced value. It does the latter, but the beginning programmer would have to look at least twice at it. Its one of two lines in a CRC checksum calculation. Whats really scary to me is the *dataBlkPtr++, because the order of operations is not very clear to the code reader. Does it post-increment the dereferenced value, or does it post-increment the pointer after it provides the dereferenced value.

It does the latter, but the beginning programmer would have to look at least twice at it.

]]> By: Alex http://squaregalaxy.com/tech/what-bothers-you-most-about-this-code/comment-page-1/#comment-7484 Alex Tue, 01 Apr 2008 22:04:32 +0000 http://jacob.peargrove.com/tech/?p=75#comment-7484 That's pretty gnarly. Please tell me that's not part of a for loop declaration. As far as what bothers me about it, it reminds me a lot of some 324 homework... What is it checking for? I'm assuming i is going to be checked against another mask? And I'm _really_ not a fan of casting things to unsigned ints that weren't originally intended to be unsigned. That’s pretty gnarly. Please tell me that’s not part of a for loop declaration.

As far as what bothers me about it, it reminds me a lot of some 324 homework…

What is it checking for? I’m assuming i is going to be checked against another mask?

And I’m _really_ not a fan of casting things to unsigned ints that weren’t originally intended to be unsigned.

]]>